Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2147213003:
Update test expectations for inspector/console/console-stack-overflow (Closed)
|
Created:
4 years, 5 months ago by jgruber Modified:
4 years, 5 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate test expectations for inspector/console/console-stack-overflow
BUG=624285
Committed: https://crrev.com/b5683a83ccd74dbad544ce2fc0bc1af910352aa3
Cr-Commit-Position: refs/heads/master@{#405987}
Patch Set 1 #Patch Set 2 : Set to NeedsRebaseline instead #Messages
Total messages: 21 (10 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jgruber@chromium.org changed reviewers: + kozyatinskiy@chromium.org, yangguo@chromium.org
On 2016/07/15 10:54:16, jgruber wrote: lgtm.
On 2016/07/15 11:14:17, Yang wrote: > On 2016/07/15 10:54:16, jgruber wrote: > > lgtm. Lgtm
One second.. it looks like stack overflow errors are now broken in ToT.
If you run following code in console then you won't get expandable stack trace.
I'll debug it.
function overflow()
{
overflow();
}
function doOverflow()
{
setTimeout(overflow, 0);
}
// overflow();
doOverflow();
On 2016/07/16 01:18:55, kozyatinskiy wrote:
> One second.. it looks like stack overflow errors are now broken in ToT.
> If you run following code in console then you won't get expandable stack
trace.
> I'll debug it.
>
> function overflow()
> {
> overflow();
> }
>
> function doOverflow()
> {
> setTimeout(overflow, 0);
> }
>
> // overflow();
> doOverflow();
Nevermind, I rebuilt my chromium and now everything is fine.
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jgruber@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kozyatinskiy@chromium.org, yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/2147213003/#ps20001 (title: "Set to NeedsRebaseline instead")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Update test expectations for inspector/console/console-stack-overflow BUG=624285 ========== to ========== Update test expectations for inspector/console/console-stack-overflow BUG=624285 Committed: https://crrev.com/b5683a83ccd74dbad544ce2fc0bc1af910352aa3 Cr-Commit-Position: refs/heads/master@{#405987} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b5683a83ccd74dbad544ce2fc0bc1af910352aa3 Cr-Commit-Position: refs/heads/master@{#405987} |
