Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2147203003: MediaRecorder content_unittests: enable {{Video,Audio}TrackRecorder,MediaRecorderHandler}Test (Closed)

Created:
4 years, 5 months ago by mcasas
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaRecorder content_unittests: enable {{Video,Audio}TrackRecorder,MediaRecorderHandler}Test This CL enables compilation of MediaRecorder-related unittests: MediaRecorderHandlerTest VideoTrackRecorderTest AudioTrackRecorderTest BUG=628442 Committed: https://crrev.com/b15b8e1c9340de06b0792b4c163e95bf4fc2bede Cr-Commit-Position: refs/heads/master@{#405791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
mcasas
phoglund@ PTAL
4 years, 5 months ago (2016-07-15 02:54:37 UTC) #3
phoglund_chromium
lgtm
4 years, 5 months ago (2016-07-15 10:20:17 UTC) #4
mcasas
avi@ RS please
4 years, 5 months ago (2016-07-15 16:03:22 UTC) #6
Avi (use Gerrit)
moar tests moar lgtm
4 years, 5 months ago (2016-07-15 16:07:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147203003/1
4 years, 5 months ago (2016-07-15 16:08:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 18:08:21 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 18:08:39 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 18:10:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b15b8e1c9340de06b0792b4c163e95bf4fc2bede
Cr-Commit-Position: refs/heads/master@{#405791}

Powered by Google App Engine
This is Rietveld 408576698