Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2147163003: Fix summary tests on Windows. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix summary tests on Windows. The tests use Posix style files paths, so when we convert them into URIs we also should use Posix style implementation. R=paulberry@google.com BUG= https://github.com/dart-lang/sdk/issues/26828 Committed: https://github.com/dart-lang/sdk/commit/0e855cbf53f97c46563bd87f6cc200d97204fc9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scheglov
4 years, 5 months ago (2016-07-14 20:04:49 UTC) #1
Paul Berry
lgtm
4 years, 5 months ago (2016-07-14 20:07:07 UTC) #3
scheglov
4 years, 5 months ago (2016-07-14 20:09:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e855cbf53f97c46563bd87f6cc200d97204fc9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698