Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2147163002: Make removeStyleFromRulesAndContext() to use style resolver after distribution (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make removeStyleFromRulesAndContext() to use style resolver within style clean This patch makes |EditingStyle::removeStyleFromRulesAndContext()| to call |styleFromMatchedRulesForElement()| within style clean. BUG=627692 TEST=LayoutTests/editing/execCommand/insert_list/insert_list_in_summary_crash.html Committed: https://crrev.com/05e5ea2e6b758852ef19ee78cd4a7285ab1a1950 Cr-Commit-Position: refs/heads/master@{#405445}

Patch Set 1 : 2016-07-14T12:46:21 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/editing/execCommand/insert_list/insert_list_in_summary_crash.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-14 05:16:33 UTC) #5
yoichio
lgtm
4 years, 5 months ago (2016-07-14 06:09:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147163002/1
4 years, 5 months ago (2016-07-14 06:23:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 07:15:01 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 07:15:05 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 07:16:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05e5ea2e6b758852ef19ee78cd4a7285ab1a1950
Cr-Commit-Position: refs/heads/master@{#405445}

Powered by Google App Engine
This is Rietveld 408576698