|
|
DescriptionAdd finch control for use-zoom-for-dsf.
BUG=613414
Committed: https://crrev.com/9dc180d31f8452c215651ccacbf1b5fc731f479d
Cr-Commit-Position: refs/heads/master@{#405922}
Patch Set 1 #
Total comments: 2
Patch Set 2 : only compile feature on windows #Messages
Total messages: 18 (9 generated)
Description was changed from ========== Add finch control for use-zoom-for-dsf. BUG=613414 ========== to ========== Add finch control for use-zoom-for-dsf. BUG=613414 ==========
bsep@chromium.org changed reviewers: + jam@chromium.org, wfh@chromium.org
lgtm fwiw https://codereview.chromium.org/2147143003/diff/1/content/common/content_swit... File content/common/content_switches_internal.cc (right): https://codereview.chromium.org/2147143003/diff/1/content/common/content_swit... content/common/content_switches_internal.cc:23: const base::Feature kUseZoomForDsfEnabledByDefault { I use constexpr here but I think it's the same difference.
bsep@chromium.org changed reviewers: + nasko@chromium.org - jam@chromium.org
Changing reviewers because John is ooo. https://codereview.chromium.org/2147143003/diff/1/content/common/content_swit... File content/common/content_switches_internal.cc (right): https://codereview.chromium.org/2147143003/diff/1/content/common/content_swit... content/common/content_switches_internal.cc:23: const base::Feature kUseZoomForDsfEnabledByDefault { On 2016/07/14 22:42:56, Will Harris wrote: > I use constexpr here but I think it's the same difference. The example used const and this seems to work fine so I think I'll leave it.
Rubberstamp LGTM
The CQ bit was checked by bsep@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by bsep@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org, wfh@chromium.org Link to the patchset: https://codereview.chromium.org/2147143003/#ps20001 (title: "only compile feature on windows")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add finch control for use-zoom-for-dsf. BUG=613414 ========== to ========== Add finch control for use-zoom-for-dsf. BUG=613414 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add finch control for use-zoom-for-dsf. BUG=613414 ========== to ========== Add finch control for use-zoom-for-dsf. BUG=613414 Committed: https://crrev.com/9dc180d31f8452c215651ccacbf1b5fc731f479d Cr-Commit-Position: refs/heads/master@{#405922} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9dc180d31f8452c215651ccacbf1b5fc731f479d Cr-Commit-Position: refs/heads/master@{#405922} |