Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2147143003: Add finch control for use-zoom-for-dsf. (Closed)

Created:
4 years, 5 months ago by Bret
Modified:
4 years, 5 months ago
Reviewers:
nasko, Will Harris
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add finch control for use-zoom-for-dsf. BUG=613414 Committed: https://crrev.com/9dc180d31f8452c215651ccacbf1b5fc731f479d Cr-Commit-Position: refs/heads/master@{#405922}

Patch Set 1 #

Total comments: 2

Patch Set 2 : only compile feature on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M content/common/content_switches_internal.cc View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Bret
4 years, 5 months ago (2016-07-14 21:30:36 UTC) #3
Will Harris
lgtm fwiw https://codereview.chromium.org/2147143003/diff/1/content/common/content_switches_internal.cc File content/common/content_switches_internal.cc (right): https://codereview.chromium.org/2147143003/diff/1/content/common/content_switches_internal.cc#newcode23 content/common/content_switches_internal.cc:23: const base::Feature kUseZoomForDsfEnabledByDefault { I use constexpr ...
4 years, 5 months ago (2016-07-14 22:42:56 UTC) #4
Bret
Changing reviewers because John is ooo. https://codereview.chromium.org/2147143003/diff/1/content/common/content_switches_internal.cc File content/common/content_switches_internal.cc (right): https://codereview.chromium.org/2147143003/diff/1/content/common/content_switches_internal.cc#newcode23 content/common/content_switches_internal.cc:23: const base::Feature kUseZoomForDsfEnabledByDefault ...
4 years, 5 months ago (2016-07-15 18:14:28 UTC) #6
nasko
Rubberstamp LGTM
4 years, 5 months ago (2016-07-15 23:50:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147143003/1
4 years, 5 months ago (2016-07-16 00:02:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/191941)
4 years, 5 months ago (2016-07-16 00:09:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147143003/20001
4 years, 5 months ago (2016-07-16 00:33:19 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-16 02:22:38 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 02:24:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9dc180d31f8452c215651ccacbf1b5fc731f479d
Cr-Commit-Position: refs/heads/master@{#405922}

Powered by Google App Engine
This is Rietveld 408576698