ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc - Issue 2147143002: [Chrome OS MD] Draw a 1px separator between 2 tray items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc

Issue 2147143002: [Chrome OS MD] Draw a 1px separator between 2 tray items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: new approach Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/common/system/chromeos/ime_menu/ime_menu_tray.cc ('k') | ash/common/system/chromeos/palette/palette_tray.h » ('j') | ash/common/system/view_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc

diff --git a/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc b/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc

index 376e4d2dfe40c3cde287edf0d47651fa894c8c93..d32633620e987fd34c98ed22d8753dc155b1be19 100644

--- a/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc

+++ b/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc

@@ -5,6 +5,7 @@

#include "ash/common/system/chromeos/ime_menu/ime_menu_tray.h"

#include "ash/common/system/tray/system_tray_notifier.h"

+#include "ash/common/system/view_observer.h"

#include "ash/common/wm_shell.h"

#include "ash/test/ash_test_base.h"

#include "ash/test/test_system_tray_delegate.h"

@@ -26,7 +27,8 @@ class ImeMenuTrayTest : public test::AshTestBase {

// test::AshTestBase:

void SetUp() override {

test::AshTestBase::SetUp();

- ime_menu_tray_.reset(new ImeMenuTray(GetPrimaryShelf()));

+ ViewObserver* view_observer = new ViewObserver();

+ ime_menu_tray_.reset(new ImeMenuTray(GetPrimaryShelf(), view_observer));

}

void TearDown() override {