[Chrome OS MD] Draw a 1px separator between 2 tray items

ash/common/system/overview/overview_button_tray.cc

Index: ash/common/system/overview/overview_button_tray.cc
diff --git a/ash/common/system/overview/overview_button_tray.cc b/ash/common/system/overview/overview_button_tray.cc
index e3508b474c4a26553b89336f0d3ed517b8783ff8..6528a322a200a2339a56c5b9fca4e21e4d676a7f 100644
--- a/ash/common/system/overview/overview_button_tray.cc
+++ b/ash/common/system/overview/overview_button_tray.cc
@@ -123,13 +123,11 @@ void OverviewButtonTray::SetIconBorderForShelfAlignment() {
         gfx::Insets(vertical_padding, horizontal_padding)));
   } else {
     if (IsHorizontalAlignment(shelf_alignment())) {
-      icon_->SetBorder(views::Border::CreateEmptyBorder(
-          kHorizontalShelfVerticalPadding, kHorizontalShelfHorizontalPadding,
-          kHorizontalShelfVerticalPadding, kHorizontalShelfHorizontalPadding));
+      icon_->SetBorder(views::Border::CreateEmptyBorder(gfx::Insets(
+          kHorizontalShelfVerticalPadding, kHorizontalShelfHorizontalPadding)));
     } else {
-      icon_->SetBorder(views::Border::CreateEmptyBorder(
-          kVerticalShelfVerticalPadding, kVerticalShelfHorizontalPadding,
-          kVerticalShelfVerticalPadding, kVerticalShelfHorizontalPadding));
+      icon_->SetBorder(views::Border::CreateEmptyBorder(gfx::Insets(
+          kVerticalShelfVerticalPadding, kVerticalShelfHorizontalPadding)));

[varkha, 2016/08/19 16:33:39]

nit: Can you calculate insets in all 3 cases and then
icon_->SetBorder(views::Border::CreateEmptyBorder(insets)) only once?

[yiyix, 2016/08/19 19:07:55]

Done.

     }
   }
 }