ash/common/system/overview/overview_button_tray.h - Issue 2147143002: [Chrome OS MD] Draw a 1px separator between 2 tray items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/overview/overview_button_tray.h

Issue 2147143002: [Chrome OS MD] Draw a 1px separator between 2 tray items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc ('K') | « ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc ('k') | ash/common/system/overview/overview_button_tray.cc » ('j') | ash/common/system/overview/overview_button_tray.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/system/overview/overview_button_tray.h

diff --git a/ash/common/system/overview/overview_button_tray.h b/ash/common/system/overview/overview_button_tray.h

index 1654458d62aba826889cd1926270efe619de7326..593f392b7b799a16ee89405089e03596f3639877 100644

--- a/ash/common/system/overview/overview_button_tray.h

+++ b/ash/common/system/overview/overview_button_tray.h

@@ -57,6 +57,10 @@ class ASH_EXPORT OverviewButtonTray : public TrayBackgroundView,

// alignment of the shelf.

void SetIconBorderForShelfAlignment();

+ // Additional padding are used to adjust the user-visible size of overview

varkha 2016/07/14 21:34:47 nit: s/are/is More importantly the comment should

yiyix 2016/07/26 20:27:31 Done.

+ // button tray dark background in non-MD.

+ void AdjustOverviewBackground();

varkha 2016/07/14 21:34:47 Maybe SetOverviewTrayBorder() ?

yiyix 2016/07/26 20:27:31 Sure, SetOverviewTrayBorder() is more about what t

// Sets the icon to visible if maximize mode is enabled and

// WindowSelectorController::CanSelect.

void UpdateIconVisibility();