[Chrome OS MD] Draw a 1px separator between 2 tray items

ash/common/system/web_notification/web_notification_tray.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SYSTEM_WEB_NOTIFICATION_WEB_NOTIFICATION_TRAY_H_
 #define ASH_COMMON_SYSTEM_WEB_NOTIFICATION_WEB_NOTIFICATION_TRAY_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
@@ skipping 150 matching lines @@
   ui::MenuModel* CreateQuietModeMenu();
 
   WebNotificationBubbleWrapper* message_center_bubble() const {
     return message_center_bubble_.get();
   }
 
   // Returns true if any user is logged in and the system is not at the screen
   // for adding a secondary user.
   bool IsLoggedIn() const;
 
+  // views:View
+  void OnPaint(gfx::Canvas* canvas) override;
+

[varkha, 2016/07/14 21:34:48]

I think it would be better to make it protected because you are hiding it from
possible overrides in subclasses. That or move down since overrides should be
the last methods declared (a pattern I observe even though I could not find it
mentioned in the style guide).

[yiyix, 2016/07/26 20:27:32]

N/A with new approach

   // Testing accessors.
   bool IsPopupVisible() const;
   message_center::MessageCenterBubble* GetMessageCenterBubbleForTest();
 
   WmWindow* status_area_window_;
   SystemTray* system_tray_;
   std::unique_ptr<message_center::MessageCenterTray> message_center_tray_;
   std::unique_ptr<WebNotificationBubbleWrapper> message_center_bubble_;
   std::unique_ptr<message_center::MessagePopupCollection> popup_collection_;
   WebNotificationButton* button_;
 
   bool show_message_center_on_unlock_;
 
   bool should_update_tray_content_;
 
   // True when the shelf auto hide behavior has to be blocked. Previously
   // this was done by checking |message_center_bubble_| but actually
   // the check can be called when creating this object, so it would cause
   // flickers of the shelf from hidden to shown. See: crbug.com/181213
   bool should_block_shelf_auto_hide_;
 
   std::unique_ptr<AshPopupAlignmentDelegate> popup_alignment_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(WebNotificationTray);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SYSTEM_WEB_NOTIFICATION_WEB_NOTIFICATION_TRAY_H_