[Chrome OS MD] Draw a 1px separator between 2 tray items

ash/common/system/tray/tray_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_constants.h"
 
 #include "ash/common/material_design/material_design_controller.h"
 #include "base/logging.h"
 #include "third_party/skia/include/core/SkColor.h"
 
@@ skipping 66 matching lines @@
     kTrayPopupMinWidth - (kNotificationIconWidth + kNotificationButtonWidth +
                           (kTrayPopupPaddingHorizontal / 2) * 3);
 
 const int kMessageCenterBubblePadding = 4;
 
 const int kTrayIconSize = 16;
 const SkColor kTrayIconColor = SK_ColorWHITE;
 const int kMenuIconSize = 20;
 const SkColor kMenuIconColor = SkColorSetRGB(0x5A, 0x5A, 0x5A);
 
+const int kHitRegionPadding = 4;
+const SkColor kSeparatorColor = SkColorSetA(SK_ColorWHITE, 0x29);

[varkha, 2016/07/14 21:34:48]

Opacity seems quite low (16%?) so it is barely visible on black background on
hi-dpi screens. I may want to look at it on a device.

[yiyix, 2016/07/26 20:27:31]

The spec is changed to 0.24 instead. ref:
https://folio.googleplex.com/cros-core-ui/spec#%2F1.1%20-%20Shelf%20general%2...

+const int kSeparatorWidth = 1;
+
 int GetTrayConstant(TrayConstant constant) {
   const int kTrayItemHeightLegacy[] = {38, 38, kTrayItemSize};
-  const int kTraySpacing[] = {4, 4, 8};
-  const int kTrayPaddingFromEdgeOfShelf[] = {3, 3, 8};
+  const int kTraySpacing[] = {4, 4, 0};
+  const int kTrayPaddingFromEdgeOfShelf[] = {3, 3, 4};
   const int kVirtualKeyboardButtonSize[] = {39, 39, kTrayItemSize};
 
   const int mode = MaterialDesignController::GetMode();
   DCHECK(mode >= MaterialDesignController::NON_MATERIAL &&
          mode <= MaterialDesignController::MATERIAL_EXPERIMENTAL);
 
   switch (constant) {
     case TRAY_ITEM_HEIGHT_LEGACY:
       return kTrayItemHeightLegacy[mode];
     case TRAY_SPACING:
       return kTraySpacing[mode];
     case TRAY_PADDING_FROM_EDGE_OF_SHELF:
       return kTrayPaddingFromEdgeOfShelf[mode];
     case VIRTUAL_KEYBOARD_BUTTON_SIZE:
       return kVirtualKeyboardButtonSize[mode];
   }
   NOTREACHED();
   return 0;
 }
 
 }  // namespace ash