[Chrome OS MD] Draw a 1px separator between 2 tray items

ash/common/system/status_area_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/status_area_widget.h"
 
 #include "ash/common/shelf/wm_shelf.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/common/system/overview/overview_button_tray.h"
 #include "ash/common/system/status_area_widget_delegate.h"
@@ skipping 49 matching lines @@
   AddVirtualKeyboardTray();
 #endif
 
   SystemTrayDelegate* delegate = WmShell::Get()->system_tray_delegate();
   DCHECK(delegate);
   // Initialize after all trays have been created.
   system_tray_->InitializeTrayItems(delegate, web_notification_tray_);
   web_notification_tray_->Initialize();
 #if defined(OS_CHROMEOS)
   logout_button_tray_->Initialize();
-  virtual_keyboard_tray_->Initialize();
+  virtual_keyboard_tray_->InitializeTrayItems(logout_button_tray_);

[varkha, 2016/07/14 21:34:47]

See my comment about VKT::InitializeTrayIcon. Maybe just call vkt_->Initialize()
here and then vkt_->set_logout_button_tray(logout_button_tray_)

[yiyix, 2016/07/26 20:27:31]

N/A to the new approach

 #endif
   overview_button_tray_->Initialize();
   SetShelfAlignment(system_tray_->shelf_alignment());
   UpdateAfterLoginStatusChange(delegate->GetUserLoginStatus());
 }
 
 void StatusAreaWidget::Shutdown() {
   system_tray_->Shutdown();
   // Destroy the trays early, causing them to be removed from the view
   // hierarchy. Do not used scoped pointers since we don't want to destroy them
   // in the destructor if Shutdown() is not called (e.g. in tests).
   delete web_notification_tray_;
   web_notification_tray_ = NULL;
   // Must be destroyed after |web_notification_tray_|.
   delete system_tray_;
   system_tray_ = NULL;
 #if defined(OS_CHROMEOS)
+  virtual_keyboard_tray_->Shutdown();
+  delete logout_button_tray_;

[varkha, 2016/07/14 21:34:47]

nit: in a separate CL can you maybe make those owned items use auto pointers to
manage lifetime with less code?

[yiyix, 2016/07/26 20:27:31]

N/A to the new approach

+  logout_button_tray_ = NULL;

[varkha, 2016/07/14 21:34:47]

Is the changed order significant?

[yiyix, 2016/07/26 20:27:31]

N/A to the new approach

   delete virtual_keyboard_tray_;
   virtual_keyboard_tray_ = NULL;
-  delete logout_button_tray_;
-  logout_button_tray_ = NULL;
 #endif
   delete overview_button_tray_;
   overview_button_tray_ = NULL;
 }
 
 bool StatusAreaWidget::ShouldShowShelf() const {
   if ((system_tray_ && system_tray_->ShouldShowShelf()) ||
       (web_notification_tray_ &&
        web_notification_tray_->ShouldBlockShelfAutoHide()))
     return true;
@@ skipping 97 matching lines @@
     web_notification_tray_->UpdateAfterLoginStatusChange(login_status);
 #if defined(OS_CHROMEOS)
   if (logout_button_tray_)
     logout_button_tray_->UpdateAfterLoginStatusChange(login_status);
 #endif
   if (overview_button_tray_)
     overview_button_tray_->UpdateAfterLoginStatusChange(login_status);
 }
 
 }  // namespace ash