[Chrome OS MD] Draw a 1px separator between 2 tray items

ash/common/system/status_area_widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SYSTEM_STATUS_AREA_WIDGET_H_
 #define ASH_COMMON_SYSTEM_STATUS_AREA_WIDGET_H_
 
 #include "ash/ash_export.h"
 #include "ash/common/login_status.h"
 #include "ash/common/shelf/shelf_background_animator_observer.h"
 #include "ash/common/shelf/shelf_types.h"
+#include "ash/common/shelf/wm_shelf_observer.h"
 #include "base/macros.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
 class OverviewButtonTray;
 class ShellDelegate;
 class StatusAreaWidgetDelegate;
 class SystemTray;
+class TrayBackgroundView;
 class WebNotificationTray;
 class WmShelf;
 class WmWindow;
 #if defined(OS_CHROMEOS)
 class ImeMenuTray;
 class LogoutButtonTray;
 class PaletteTray;
 class VirtualKeyboardTray;
 #endif
 
 class ASH_EXPORT StatusAreaWidget : public views::Widget,
-                                    public ShelfBackgroundAnimatorObserver {
+                                    public ShelfBackgroundAnimatorObserver,
+                                    public WmShelfObserver {
  public:
   StatusAreaWidget(WmWindow* status_container, WmShelf* wm_shelf);
   ~StatusAreaWidget() override;
 
   // Creates the SystemTray, WebNotificationTray and LogoutButtonTray.
   void CreateTrayViews();
 
   // Destroys the system tray and web notification tray. Called before
   // tearing down the windows to avoid shutdown ordering issues.
   void Shutdown();
@@ skipping 36 matching lines @@
   void SchedulePaint();
 
   // Overridden from views::Widget:
   void OnNativeWidgetActivationChanged(bool active) override;
   void OnMouseEvent(ui::MouseEvent* event) override;
   void OnGestureEvent(ui::GestureEvent* event) override;
 
   // ShelfBackgroundAnimatorObserver:
   void UpdateShelfItemBackground(int alpha) override;
 
+  // Based on visibility of |tray| and tray item on its right, it sets |tray|'s

[varkha, 2016/08/10 23:27:24]

nit: remove "it" (in "it sets |tray|'s ...").

[yiyix, 2016/08/11 01:23:18]

Done.

+  // visibility of the separator either to true or false. Note that no leading
+  // separator is required before the |logout_button_tray_| because that
+  // button's red background is distinctive on its own.
+  void OnVisibilityChange(TrayBackgroundView* tray) override;

[James Cook, 2016/08/09 00:25:17]

nit: put "WmShelfObserver:" above this line and move the rest of the comment
into the .cc file

[yiyix, 2016/08/11 01:23:19]

Done.

+
  private:
   void AddSystemTray();
   void AddWebNotificationTray();
 #if defined(OS_CHROMEOS)
   void AddLogoutButtonTray();
   void AddPaletteTray();
   void AddVirtualKeyboardTray();
   void AddImeMenuTray();
 #endif
   void AddOverviewButtonTray();
@@ skipping 12 matching lines @@
   LoginStatus login_status_;
 
   WmShelf* wm_shelf_;
 
   DISALLOW_COPY_AND_ASSIGN(StatusAreaWidget);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SYSTEM_STATUS_AREA_WIDGET_H_