Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 214713006: Add GM expectations for Test-Linux-Bare-NoGPU-Arm8_64-Debug (Closed)

Created:
6 years, 9 months ago by hal.canary
Modified:
6 years, 9 months ago
Reviewers:
epoger, borenet, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add GM expectations for Test-Linux-Bare-NoGPU-Arm8_64-Debug NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2688 lines, -3232 lines) Patch
A + expectations/gm/Test-Linux-Bare-NoGPU-Arm8_64-Debug/expected-results.json View 1 chunk +2688 lines, -3232 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
hal.canary
6 years, 9 months ago (2014-03-27 16:02:35 UTC) #1
djsollen
looks good here, but I think you'll want eric or elliot to confirm that the ...
6 years, 9 months ago (2014-03-27 17:06:28 UTC) #2
hal.canary
6 years, 9 months ago (2014-03-27 17:27:10 UTC) #3
borenet
LGTM.
6 years, 9 months ago (2014-03-27 17:31:43 UTC) #4
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-27 17:36:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/214713006/1
6 years, 9 months ago (2014-03-27 17:36:04 UTC) #6
epoger
LGTM If you want this to land in spite of the closed tree, add NOTREECHECKS=True ...
6 years, 9 months ago (2014-03-27 17:59:52 UTC) #7
hal.canary
On 2014/03/27 17:59:52, epoger wrote: > LGTM > > If you want this to land ...
6 years, 9 months ago (2014-03-27 18:01:26 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 14:19:18 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 14:19:19 UTC) #10
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-28 14:20:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/214713006/1
6 years, 9 months ago (2014-03-28 14:20:27 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 14:20:37 UTC) #13
Message was sent while issue was closed.
Change committed as 13969

Powered by Google App Engine
This is Rietveld 408576698