Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2147123003: Editing: Add a TODO comment to tidyUpHTMLStructure(). (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: Add a TODO comment to tidyUpHTMLStructure(). Also, add a UseCounter to measure how many times this function updates documents. BUG=580941 Committed: https://crrev.com/e6948292cfe679fd70472c851bf099414d10c8a1 Cr-Commit-Position: refs/heads/master@{#405395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
tkent
yosin@, would you review this please?
4 years, 5 months ago (2016-07-14 00:59:38 UTC) #4
yosin_UTC9
lgtm Thanks for follow up!
4 years, 5 months ago (2016-07-14 01:03:20 UTC) #5
tkent
TBRing isherman@chromium.org for histograms.xml
4 years, 5 months ago (2016-07-14 01:05:12 UTC) #8
Ilya Sherman
histograms.xml lgtm
4 years, 5 months ago (2016-07-14 01:06:03 UTC) #9
tkent
Thank you for the quick review! Removing TBR.
4 years, 5 months ago (2016-07-14 01:06:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147123003/1
4 years, 5 months ago (2016-07-14 01:37:16 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 01:44:19 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 01:44:25 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 01:47:02 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6948292cfe679fd70472c851bf099414d10c8a1
Cr-Commit-Position: refs/heads/master@{#405395}

Powered by Google App Engine
This is Rietveld 408576698