Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2147113002: [wasm] Drop unused variables in asm-types-unittest. (Closed)

Created:
4 years, 5 months ago by bradnelson
Modified:
4 years, 5 months ago
Reviewers:
bradn, John
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Drop unused variables in asm-types-unittest. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer LOG=N R=jpp@chromium.org Committed: https://crrev.com/304572c953a421048f8e50fd6e24fdae9ea0d98a Cr-Commit-Position: refs/heads/master@{#37733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/unittests/wasm/asm-types-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
bradn
4 years, 5 months ago (2016-07-13 23:20:15 UTC) #4
John
lgtm
4 years, 5 months ago (2016-07-13 23:29:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147113002/1
4 years, 5 months ago (2016-07-13 23:29:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 23:52:13 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:53:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/304572c953a421048f8e50fd6e24fdae9ea0d98a
Cr-Commit-Position: refs/heads/master@{#37733}

Powered by Google App Engine
This is Rietveld 408576698