Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2147093002: Recognize WEBGL extensions on Firefox (Closed)

Created:
4 years, 5 months ago by sra1
Modified:
4 years, 4 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Closed. Committed independently. ---- Recognize WEBGL extensions on Firefox Both of the following objects need to map to Dart type 'AngleInstancedArrays' [object ANGLEInstancedArrays] [object ANGLE_instanced_arrays] Fixes https://github.com/dart-lang/sdk/issues/26850 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -2 lines) Patch
M tests/html/html.status View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/html/webgl_extensions_test.dart View 1 chunk +199 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +35 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
sra1
Hi Alan, Can you shepherd this through the process of regenerating web_gl.dart and updating html.status ...
4 years, 5 months ago (2016-07-13 23:10:27 UTC) #3
Alan Knight
4 years, 5 months ago (2016-07-14 17:25:00 UTC) #4 
On 2016/07/13 23:10:27, sra1 wrote:
> Hi Alan,
> 
> Can you shepherd this through the process of regenerating web_gl.dart and
> updating html.status for other browsers.
> I expect Chrome and Firefox to pass.

It seems fine, but I can't land, or even upload into, this CL. I guess I'll make
another one that's a copy and send it to you for review.

Powered by Google App Engine
This is Rietveld 408576698