Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2147083002: Revert of Rearrange Flash component registration. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rearrange Flash component registration. (patchset #1 id:1 of https://codereview.chromium.org/2130803003/ ) Reason for revert: I think this breaks some flash and eme-related internal tests. See crbug.com/627959. Original issue's description: > Rearrange Flash component registration. > (1) Remove redundant checks for bundled vs. component-updated Flash: > This distinction is handled at registration time by the DCI. > (2) Update PathService after calling register. These two events are > already racy, and it's more convenient to have the registration > finished by the time the component updater notifies that the > component has been updated. > (3) No need to explicitly pick up the bundled version of Flash for non- > Linux: the component updater will manage registration of bundled > Flash the same way it does component-updated Flash. > > BUG=624067 > TEST=https://docs.google.com/document/d/1iTQiaqjuHsKV4cPqSOet-eJKWb2SsJLp2ieDj_Mul4s/edit?pref=2&pli=1 > > Committed: https://crrev.com/ae2a704ab712680c8b53a86e77eba78d0e591106 > Cr-Commit-Position: refs/heads/master@{#405148} TBR=wfh@chromium.org,kerrnel@chromium.org,thakis@chromium.org,waffles@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624067 Committed: https://crrev.com/ab29f4c47722399870552af4ac20d76cd070d4ee Cr-Commit-Position: refs/heads/master@{#405305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 6 chunks +13 lines, -8 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
Created Revert of Rearrange Flash component registration.
4 years, 5 months ago (2016-07-13 22:15:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147083002/1
4 years, 5 months ago (2016-07-13 22:15:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 22:17:08 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 22:17:45 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 22:19:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab29f4c47722399870552af4ac20d76cd070d4ee
Cr-Commit-Position: refs/heads/master@{#405305}

Powered by Google App Engine
This is Rietveld 408576698