Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: src/interface-descriptors.h

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/x87/stub-cache-x87.cc ('k') | src/interface-descriptors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interface-descriptors.h
diff --git a/src/interface-descriptors.h b/src/interface-descriptors.h
index 3f08354f8ed10060b7d6fe1dcebaa53cbfc5114c..3a46114f4bb249e9ac937e31b024bcf838469bcf 100644
--- a/src/interface-descriptors.h
+++ b/src/interface-descriptors.h
@@ -24,14 +24,13 @@ class PlatformInterfaceDescriptor;
V(OnStackWith6Args) \
V(OnStackWith7Args) \
V(Load) \
+ V(LoadWithVector) \
V(LoadGlobal) \
V(LoadGlobalWithVector) \
V(Store) \
+ V(StoreWithVector) \
V(StoreTransition) \
V(VectorStoreTransition) \
- V(VectorStoreICTrampoline) \
- V(VectorStoreIC) \
- V(LoadWithVector) \
V(VarArgFunction) \
V(FastNewClosure) \
V(FastNewFunctionContext) \
@@ -201,7 +200,7 @@ class CallInterfaceDescriptor {
const char* DebugName(Isolate* isolate) const;
static FunctionType* BuildDefaultFunctionType(Isolate* isolate,
- int paramater_count);
+ int parameter_count);
protected:
const CallInterfaceDescriptorData* data() const { return data_; }
@@ -384,17 +383,15 @@ class LoadGlobalDescriptor : public CallInterfaceDescriptor {
class StoreDescriptor : public CallInterfaceDescriptor {
public:
- DECLARE_DESCRIPTOR(StoreDescriptor, CallInterfaceDescriptor)
+ DECLARE_DESCRIPTOR_WITH_CUSTOM_FUNCTION_TYPE(StoreDescriptor,
+ CallInterfaceDescriptor)
+
+ enum ParameterIndices { kReceiverIndex, kNameIndex, kValueIndex, kSlotIndex };
- enum ParameterIndices {
- kReceiverIndex,
- kNameIndex,
- kValueIndex,
- kParameterCount
- };
static const Register ReceiverRegister();
static const Register NameRegister();
static const Register ValueRegister();
+ static const Register SlotRegister();
};
@@ -440,22 +437,10 @@ class VectorStoreTransitionDescriptor : public StoreDescriptor {
static const Register VectorRegister();
};
-
-class VectorStoreICTrampolineDescriptor : public StoreDescriptor {
- public:
- DECLARE_DESCRIPTOR_WITH_CUSTOM_FUNCTION_TYPE(
- VectorStoreICTrampolineDescriptor, StoreDescriptor)
-
- enum ParameterIndices { kReceiverIndex, kNameIndex, kValueIndex, kSlotIndex };
-
- static const Register SlotRegister();
-};
-
-
-class VectorStoreICDescriptor : public VectorStoreICTrampolineDescriptor {
+class StoreWithVectorDescriptor : public StoreDescriptor {
public:
- DECLARE_DESCRIPTOR_WITH_CUSTOM_FUNCTION_TYPE(
- VectorStoreICDescriptor, VectorStoreICTrampolineDescriptor)
+ DECLARE_DESCRIPTOR_WITH_CUSTOM_FUNCTION_TYPE(StoreWithVectorDescriptor,
+ StoreDescriptor)
enum ParameterIndices {
kReceiverIndex,
« no previous file with comments | « src/ic/x87/stub-cache-x87.cc ('k') | src/interface-descriptors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698