Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: src/ic/ia32/stub-cache-ia32.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ic/ia32/stub-cache-ia32.cc
diff --git a/src/ic/ia32/stub-cache-ia32.cc b/src/ic/ia32/stub-cache-ia32.cc
index 0ee296c2a4dbc86032055b26bc10c0e044c70ca3..cd608a62da82d645b43266d55fb820738bf71bbb 100644
--- a/src/ic/ia32/stub-cache-ia32.cc
+++ b/src/ic/ia32/stub-cache-ia32.cc
@@ -64,8 +64,8 @@ static void ProbeTable(StubCache* stub_cache, MacroAssembler* masm,
// probe, and need to be dropped before calling the handler.
if (is_vector_store) {
// The overlap here is rather embarrassing. One does what one must.
- Register vector = VectorStoreICDescriptor::VectorRegister();
- DCHECK(extra.is(VectorStoreICDescriptor::SlotRegister()));
+ Register vector = StoreWithVectorDescriptor::VectorRegister();
+ DCHECK(extra.is(StoreWithVectorDescriptor::SlotRegister()));
__ add(extra, Immediate(Code::kHeaderSize - kHeapObjectTag));
__ pop(vector);
__ mov(Operand::StaticVariable(virtual_register), extra);
@@ -123,8 +123,8 @@ static void ProbeTable(StubCache* stub_cache, MacroAssembler* masm,
if (is_vector_store) {
// The vector and slot were pushed onto the stack before starting the
// probe, and need to be dropped before calling the handler.
- Register vector = VectorStoreICDescriptor::VectorRegister();
- DCHECK(offset.is(VectorStoreICDescriptor::SlotRegister()));
+ Register vector = StoreWithVectorDescriptor::VectorRegister();
+ DCHECK(offset.is(StoreWithVectorDescriptor::SlotRegister()));
__ add(offset, Immediate(Code::kHeaderSize - kHeapObjectTag));
__ mov(Operand::StaticVariable(virtual_register), offset);
__ pop(vector);

Powered by Google App Engine
This is Rietveld 408576698