Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Side by Side Diff: src/ic/arm64/stub-cache-arm64.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: Rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 DCHECK(!extra2.is(no_reg)); 102 DCHECK(!extra2.is(no_reg));
103 DCHECK(!extra3.is(no_reg)); 103 DCHECK(!extra3.is(no_reg));
104 104
105 #ifdef DEBUG 105 #ifdef DEBUG
106 // If vector-based ics are in use, ensure that scratch, extra, extra2 and 106 // If vector-based ics are in use, ensure that scratch, extra, extra2 and
107 // extra3 don't conflict with the vector and slot registers, which need 107 // extra3 don't conflict with the vector and slot registers, which need
108 // to be preserved for a handler call or miss. 108 // to be preserved for a handler call or miss.
109 if (IC::ICUseVector(ic_kind_)) { 109 if (IC::ICUseVector(ic_kind_)) {
110 Register vector, slot; 110 Register vector, slot;
111 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) { 111 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) {
112 vector = VectorStoreICDescriptor::VectorRegister(); 112 vector = StoreWithVectorDescriptor::VectorRegister();
113 slot = VectorStoreICDescriptor::SlotRegister(); 113 slot = StoreWithVectorDescriptor::SlotRegister();
114 } else { 114 } else {
115 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC); 115 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC);
116 vector = LoadWithVectorDescriptor::VectorRegister(); 116 vector = LoadWithVectorDescriptor::VectorRegister();
117 slot = LoadWithVectorDescriptor::SlotRegister(); 117 slot = LoadWithVectorDescriptor::SlotRegister();
118 } 118 }
119 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3)); 119 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3));
120 } 120 }
121 #endif 121 #endif
122 122
123 Counters* counters = masm->isolate()->counters(); 123 Counters* counters = masm->isolate()->counters();
(...skipping 26 matching lines...) Expand all
150 // Cache miss: Fall-through and let caller handle the miss by 150 // Cache miss: Fall-through and let caller handle the miss by
151 // entering the runtime system. 151 // entering the runtime system.
152 __ Bind(&miss); 152 __ Bind(&miss);
153 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 153 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
154 extra3); 154 extra3);
155 } 155 }
156 } // namespace internal 156 } // namespace internal
157 } // namespace v8 157 } // namespace v8
158 158
159 #endif // V8_TARGET_ARCH_ARM64 159 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698