Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: src/ic/x64/stub-cache-x64.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 // If vector-based ics are in use, ensure that scratch doesn't conflict with 105 // If vector-based ics are in use, ensure that scratch doesn't conflict with
106 // the vector and slot registers, which need to be preserved for a handler 106 // the vector and slot registers, which need to be preserved for a handler
107 // call or miss. 107 // call or miss.
108 if (IC::ICUseVector(ic_kind_)) { 108 if (IC::ICUseVector(ic_kind_)) {
109 if (ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC) { 109 if (ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC) {
110 Register vector = LoadWithVectorDescriptor::VectorRegister(); 110 Register vector = LoadWithVectorDescriptor::VectorRegister();
111 Register slot = LoadDescriptor::SlotRegister(); 111 Register slot = LoadDescriptor::SlotRegister();
112 DCHECK(!AreAliased(vector, slot, scratch)); 112 DCHECK(!AreAliased(vector, slot, scratch));
113 } else { 113 } else {
114 DCHECK(ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC); 114 DCHECK(ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC);
115 Register vector = VectorStoreICDescriptor::VectorRegister(); 115 Register vector = StoreWithVectorDescriptor::VectorRegister();
116 Register slot = VectorStoreICDescriptor::SlotRegister(); 116 Register slot = StoreWithVectorDescriptor::SlotRegister();
117 DCHECK(!AreAliased(vector, slot, scratch)); 117 DCHECK(!AreAliased(vector, slot, scratch));
118 } 118 }
119 } 119 }
120 #endif 120 #endif
121 121
122 Counters* counters = masm->isolate()->counters(); 122 Counters* counters = masm->isolate()->counters();
123 __ IncrementCounter(counters->megamorphic_stub_cache_probes(), 1); 123 __ IncrementCounter(counters->megamorphic_stub_cache_probes(), 1);
124 124
125 // Check that the receiver isn't a smi. 125 // Check that the receiver isn't a smi.
126 __ JumpIfSmi(receiver, &miss); 126 __ JumpIfSmi(receiver, &miss);
(...skipping 27 matching lines...) Expand all
154 __ bind(&miss); 154 __ bind(&miss);
155 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1); 155 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1);
156 } 156 }
157 157
158 158
159 #undef __ 159 #undef __
160 } // namespace internal 160 } // namespace internal
161 } // namespace v8 161 } // namespace v8
162 162
163 #endif // V8_TARGET_ARCH_X64 163 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698