Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Side by Side Diff: src/ic/ppc/stub-cache-ppc.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 DCHECK(!extra2.is(no_reg)); 128 DCHECK(!extra2.is(no_reg));
129 DCHECK(!extra3.is(no_reg)); 129 DCHECK(!extra3.is(no_reg));
130 130
131 #ifdef DEBUG 131 #ifdef DEBUG
132 // If vector-based ics are in use, ensure that scratch, extra, extra2 and 132 // If vector-based ics are in use, ensure that scratch, extra, extra2 and
133 // extra3 don't conflict with the vector and slot registers, which need 133 // extra3 don't conflict with the vector and slot registers, which need
134 // to be preserved for a handler call or miss. 134 // to be preserved for a handler call or miss.
135 if (IC::ICUseVector(ic_kind_)) { 135 if (IC::ICUseVector(ic_kind_)) {
136 Register vector, slot; 136 Register vector, slot;
137 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) { 137 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) {
138 vector = VectorStoreICDescriptor::VectorRegister(); 138 vector = StoreWithVectorDescriptor::VectorRegister();
139 slot = VectorStoreICDescriptor::SlotRegister(); 139 slot = StoreWithVectorDescriptor::SlotRegister();
140 } else { 140 } else {
141 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC); 141 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC);
142 vector = LoadWithVectorDescriptor::VectorRegister(); 142 vector = LoadWithVectorDescriptor::VectorRegister();
143 slot = LoadWithVectorDescriptor::SlotRegister(); 143 slot = LoadWithVectorDescriptor::SlotRegister();
144 } 144 }
145 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3)); 145 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3));
146 } 146 }
147 #endif 147 #endif
148 148
149 Counters* counters = masm->isolate()->counters(); 149 Counters* counters = masm->isolate()->counters();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 182 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
183 extra3); 183 extra3);
184 } 184 }
185 185
186 186
187 #undef __ 187 #undef __
188 } // namespace internal 188 } // namespace internal
189 } // namespace v8 189 } // namespace v8
190 190
191 #endif // V8_TARGET_ARCH_PPC 191 #endif // V8_TARGET_ARCH_PPC
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698