Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: src/ic/mips/stub-cache-mips.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 DCHECK(!extra2.is(no_reg)); 105 DCHECK(!extra2.is(no_reg));
106 DCHECK(!extra3.is(no_reg)); 106 DCHECK(!extra3.is(no_reg));
107 107
108 #ifdef DEBUG 108 #ifdef DEBUG
109 // If vector-based ics are in use, ensure that scratch, extra, extra2 and 109 // If vector-based ics are in use, ensure that scratch, extra, extra2 and
110 // extra3 don't conflict with the vector and slot registers, which need 110 // extra3 don't conflict with the vector and slot registers, which need
111 // to be preserved for a handler call or miss. 111 // to be preserved for a handler call or miss.
112 if (IC::ICUseVector(ic_kind_)) { 112 if (IC::ICUseVector(ic_kind_)) {
113 Register vector, slot; 113 Register vector, slot;
114 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) { 114 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) {
115 vector = VectorStoreICDescriptor::VectorRegister(); 115 vector = StoreWithVectorDescriptor::VectorRegister();
116 slot = VectorStoreICDescriptor::SlotRegister(); 116 slot = StoreWithVectorDescriptor::SlotRegister();
117 } else { 117 } else {
118 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC); 118 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC);
119 vector = LoadWithVectorDescriptor::VectorRegister(); 119 vector = LoadWithVectorDescriptor::VectorRegister();
120 slot = LoadWithVectorDescriptor::SlotRegister(); 120 slot = LoadWithVectorDescriptor::SlotRegister();
121 } 121 }
122 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3)); 122 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3));
123 } 123 }
124 #endif 124 #endif
125 125
126 Counters* counters = masm->isolate()->counters(); 126 Counters* counters = masm->isolate()->counters();
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 162 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
163 extra3); 163 extra3);
164 } 164 }
165 165
166 166
167 #undef __ 167 #undef __
168 } // namespace internal 168 } // namespace internal
169 } // namespace v8 169 } // namespace v8
170 170
171 #endif // V8_TARGET_ARCH_MIPS 171 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698