Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic/arm/stub-cache-arm.cc

Issue 2147043002: Cleanup interface descriptors to reflect that vectors are part of stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rename-store-ic
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 DCHECK(!extra2.is(no_reg)); 111 DCHECK(!extra2.is(no_reg));
112 DCHECK(!extra3.is(no_reg)); 112 DCHECK(!extra3.is(no_reg));
113 113
114 #ifdef DEBUG 114 #ifdef DEBUG
115 // If vector-based ics are in use, ensure that scratch, extra, extra2 and 115 // If vector-based ics are in use, ensure that scratch, extra, extra2 and
116 // extra3 don't conflict with the vector and slot registers, which need 116 // extra3 don't conflict with the vector and slot registers, which need
117 // to be preserved for a handler call or miss. 117 // to be preserved for a handler call or miss.
118 if (IC::ICUseVector(ic_kind_)) { 118 if (IC::ICUseVector(ic_kind_)) {
119 Register vector, slot; 119 Register vector, slot;
120 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) { 120 if (ic_kind_ == Code::STORE_IC || ic_kind_ == Code::KEYED_STORE_IC) {
121 vector = VectorStoreICDescriptor::VectorRegister(); 121 vector = StoreWithVectorDescriptor::VectorRegister();
122 slot = VectorStoreICDescriptor::SlotRegister(); 122 slot = StoreWithVectorDescriptor::SlotRegister();
123 } else { 123 } else {
124 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC); 124 DCHECK(ic_kind_ == Code::LOAD_IC || ic_kind_ == Code::KEYED_LOAD_IC);
125 vector = LoadWithVectorDescriptor::VectorRegister(); 125 vector = LoadWithVectorDescriptor::VectorRegister();
126 slot = LoadWithVectorDescriptor::SlotRegister(); 126 slot = LoadWithVectorDescriptor::SlotRegister();
127 } 127 }
128 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3)); 128 DCHECK(!AreAliased(vector, slot, scratch, extra, extra2, extra3));
129 } 129 }
130 #endif 130 #endif
131 131
132 Counters* counters = masm->isolate()->counters(); 132 Counters* counters = masm->isolate()->counters();
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 170 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
171 extra3); 171 extra3);
172 } 172 }
173 173
174 174
175 #undef __ 175 #undef __
176 } // namespace internal 176 } // namespace internal
177 } // namespace v8 177 } // namespace v8
178 178
179 #endif // V8_TARGET_ARCH_ARM 179 #endif // V8_TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698