Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 214703003: Remove "all_webkit" target. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
CC:
chromium-reviews, abarth-chromium
Visibility:
Public.

Description

Remove "all_webkit" target. Everybody should be building blink_tests right now. As it is today all_webkit is just an alias to blink_tests. It was added by r233699 - https://codereview.chromium.org/59233012 Blink side - https://codereview.chromium.org/191973002 Nobody seems to be using it anymore. BUG=None TEST=None (no functional changes). R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
6 years, 9 months ago (2014-03-27 13:13:01 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-27 14:19:50 UTC) #2
jochen (gone - plz use gerrit)
please send a PSA to blink-dev@ in case somebody is still using it, and change ...
6 years, 9 months ago (2014-03-27 14:20:31 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-27 16:57:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/214703003/1
6 years, 9 months ago (2014-03-27 16:58:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 18:03:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57961
6 years, 9 months ago (2014-03-27 18:03:12 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-27 18:54:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/214703003/1
6 years, 9 months ago (2014-03-27 18:55:28 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:54:50 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) crypto_unittests, url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136511
6 years, 9 months ago (2014-03-27 23:54:51 UTC) #11
tfarina
6 years, 9 months ago (2014-03-28 02:39:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 manually as r260063 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698