|
|
Chromium Code Reviews
DescriptionMark POWER key as system key so that it won't be passed to regular apps.
BUG=628240
,b/30105805
Committed: https://crrev.com/9ab677c3c450345d2e7f34dc207c463aea8901d3
Cr-Commit-Position: refs/heads/master@{#405830}
Patch Set 1 #
Total comments: 1
Patch Set 2 : git cl format #
Messages
Total messages: 32 (21 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
oshima@chromium.org changed reviewers: + mtomasz@chromium.org, sadrul@chromium.org
mtomasz@ -> system key change sadrul@ -> ui/wm/core owner https://codereview.chromium.org/2147013003/diff/1/ui/wm/core/accelerator_dele... File ui/wm/core/accelerator_delegate.h (left): https://codereview.chromium.org/2147013003/diff/1/ui/wm/core/accelerator_dele... ui/wm/core/accelerator_delegate.h:24: looks like these classes are used only in ash, so we can move them to ash/accelerator. I don't remember original plan, but I think it's safe to move it to ash. Let me know if you want to do it now, otherwise, I'll do that in a separate CL.
lgtm. I also checked locally with this CL and the issue doesn't reproduce anymore.
Description was changed from ========== Mark POWER key as system key so that it won't be passed to regular apps. BUG=b/30105805 ========== to ========== Mark POWER key as system key so that it won't be passed to regular apps. BUG=628240,b/30105805 ==========
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by oshima@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by oshima@chromium.org
oshima@chromium.org changed reviewers: - oshima@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by oshima@chromium.org
The CQ bit was checked by oshima@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org, sadrul@chromium.org Link to the patchset: https://codereview.chromium.org/2147013003/#ps20001 (title: "git cl format")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Mark POWER key as system key so that it won't be passed to regular apps. BUG=628240,b/30105805 ========== to ========== Mark POWER key as system key so that it won't be passed to regular apps. BUG=628240,b/30105805 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Mark POWER key as system key so that it won't be passed to regular apps. BUG=628240,b/30105805 ========== to ========== Mark POWER key as system key so that it won't be passed to regular apps. BUG=628240,b/30105805 Committed: https://crrev.com/9ab677c3c450345d2e7f34dc207c463aea8901d3 Cr-Commit-Position: refs/heads/master@{#405830} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9ab677c3c450345d2e7f34dc207c463aea8901d3 Cr-Commit-Position: refs/heads/master@{#405830} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
