Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 2147013003: Mark POWER key as system key so that it won't be passed to regular apps. (Closed)

Created:
4 years, 5 months ago by oshima
Modified:
4 years, 5 months ago
Reviewers:
mtomasz, sadrul
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark POWER key as system key so that it won't be passed to regular apps. BUG=628240 ,b/30105805 Committed: https://crrev.com/9ab677c3c450345d2e7f34dc207c463aea8901d3 Cr-Commit-Position: refs/heads/master@{#405830}

Patch Set 1 #

Total comments: 1

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -43 lines) Patch
M ash/accelerators/accelerator_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M ash/accelerators/accelerator_delegate.cc View 1 1 chunk +30 lines, -4 lines 0 comments Download
M ui/wm/core/accelerator_delegate.h View 1 chunk +1 line, -8 lines 0 comments Download
M ui/wm/core/accelerator_filter.cc View 2 chunks +1 line, -29 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
oshima
mtomasz@ -> system key change sadrul@ -> ui/wm/core owner https://codereview.chromium.org/2147013003/diff/1/ui/wm/core/accelerator_delegate.h File ui/wm/core/accelerator_delegate.h (left): https://codereview.chromium.org/2147013003/diff/1/ui/wm/core/accelerator_delegate.h#oldcode24 ui/wm/core/accelerator_delegate.h:24: ...
4 years, 5 months ago (2016-07-13 21:29:31 UTC) #6
mtomasz
lgtm. I also checked locally with this CL and the issue doesn't reproduce anymore.
4 years, 5 months ago (2016-07-14 03:01:37 UTC) #7
sadrul
lgtm
4 years, 5 months ago (2016-07-15 14:23:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147013003/1
4 years, 5 months ago (2016-07-15 14:29:11 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/218906)
4 years, 5 months ago (2016-07-15 14:36:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147013003/1
4 years, 5 months ago (2016-07-15 15:22:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147013003/20001
4 years, 5 months ago (2016-07-15 15:26:39 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/256647)
4 years, 5 months ago (2016-07-15 17:28:38 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147013003/20001
4 years, 5 months ago (2016-07-15 19:02:53 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 19:51:08 UTC) #30
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 19:52:57 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ab677c3c450345d2e7f34dc207c463aea8901d3
Cr-Commit-Position: refs/heads/master@{#405830}

Powered by Google App Engine
This is Rietveld 408576698