Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2147003002: Revert "SVGLength.value setter should set the value to <number>" (Closed)

Created:
4 years, 5 months ago by eae
Modified:
4 years, 5 months ago
Reviewers:
Shanmuga Pandi
CC:
chromium-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "SVGLength.value setter should set the value to <number>" This reverts r403440 (commit c825d655f6aaf73484f9d56e9012793f5b9668cc), as it caused a security regression. BUG=626790 TBR=shanmuga.m@samsung.com Committed: https://crrev.com/8583ce1a114e429f617e4ab8eda196ca42a78386 Cr-Commit-Position: refs/heads/master@{#405264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
D third_party/WebKit/LayoutTests/svg/dom/SVGLength-value-setter.html View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147003002/1
4 years, 5 months ago (2016-07-13 18:04:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:16:57 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:19:22 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8583ce1a114e429f617e4ab8eda196ca42a78386
Cr-Commit-Position: refs/heads/master@{#405264}

Powered by Google App Engine
This is Rietveld 408576698