RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation

RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation

Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support.

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.

Committed: https://crrev.com/d4179235b928634aeadb0c3379d385caf0ad3a07
Cr-Commit-Position: refs/heads/master@{#405243}

[mcasas, 2016-07-13 17:50:19]

Description was changed from

==========
RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation


Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, which possibly has no
real WebCam. The solution is to test if
 [captureSession_ canAddOutput:...]


Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html
==========

to

==========
RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation


Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support. 

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

[mcasas, 2016-07-13 18:33:57]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:35:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:56:16]

Description was changed from

==========
RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation


Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support. 

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

to

==========
RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation


Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support. 

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

[commit-bot: I haz the power, 2016-07-13 19:56:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 19:56:24]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 19:57:53]

Description was changed from

==========
RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation


Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support. 

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.
==========

to

==========
RELAND: ImageCapture: Implement takePhoto() for Mac AVFoundation

Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support.

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.

Committed: https://crrev.com/d4179235b928634aeadb0c3379d385caf0ad3a07
Cr-Commit-Position: refs/heads/master@{#405243}
==========

[commit-bot: I haz the power, 2016-07-13 19:57:54]

Patchset 2 (id:??) landed as
https://crrev.com/d4179235b928634aeadb0c3379d385caf0ad3a07
Cr-Commit-Position: refs/heads/master@{#405243}

[mcasas, 2016-07-13 21:26:22]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2151443003/ by mcasas@chromium.org.

The reason for reverting is: It caused timeout in
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0

see
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/56929.