chrome/browser/extensions/pending_extension_info.h - Issue 2146963004: Adding the creation flags back to pending extension info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/pending_extension_info.h

Issue 2146963004: Adding the creation flags back to pending extension info. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test to update extension with flag before installtion Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service_unittest.cc ('K') | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/pending_extension_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/pending_extension_info.h

diff --git a/chrome/browser/extensions/pending_extension_info.h b/chrome/browser/extensions/pending_extension_info.h

index 8bfcdaa9707698d7b30e67678164f2d15fc475d0..9d4e939180e34a55fbb5592cef1260f760f6fd68 100644

--- a/chrome/browser/extensions/pending_extension_info.h

+++ b/chrome/browser/extensions/pending_extension_info.h

@@ -34,6 +34,7 @@ class PendingExtensionInfo {

ShouldAllowInstallPredicate should_allow_install,

bool is_from_sync,

Manifest::Location install_source,

+ int creation_flags,

bool mark_acknowledged,

bool remote_install);

@@ -63,6 +64,7 @@ class PendingExtensionInfo {

}

bool is_from_sync() const { return is_from_sync_; }

Manifest::Location install_source() const { return install_source_; }

+ int creation_flags() const { return creation_flags_; }

bool mark_acknowledged() const { return mark_acknowledged_; }

bool remote_install() const { return remote_install_; }

@@ -87,6 +89,7 @@ class PendingExtensionInfo {

bool is_from_sync_; // This update check was initiated from sync.

Manifest::Location install_source_;

+ int creation_flags_;

bool mark_acknowledged_;

bool remote_install_;