Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: PRESUBMIT.py

Issue 2146933002: Get rid of GetPreferredTryMasters. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index da195a49c20e086390a4f15500c7ce9013b2d58d..f40b33b192681746ab22d2f5254b0243dd7da9cc 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -386,28 +386,3 @@ def CheckChangeOnCommit(input_api, output_api): # pragma: no cover
output_api,
json_url='http://infra-status.appspot.com/current?format=json'))
return output
-
-
-# Unused argument - pylint: disable=W0613
-def GetPreferredTryMasters(project, change): # pragma: no cover
- import json
- import os.path
- import platform
- import subprocess
- cq_config_path = os.path.join(
- change.RepositoryRoot(), 'config', 'cq.cfg')
- # commit_queue.py below is a script in depot_tools directory, which has a
- # 'builders' command to retrieve a list of CQ builders from the CQ config.
- is_win = platform.system() == 'Windows'
- masters = json.loads(subprocess.check_output(
- ['commit_queue', 'builders', cq_config_path], shell=is_win))
- try_config = {}
- for master in masters:
- try_config.setdefault(master, {})
- for builder in masters[master]:
- # Do not trigger presubmit builders, since they're likely to fail
- # (e.g. OWNERS checks before finished code review), and we're
- # running local presubmit anyway.
- if 'presubmit' not in builder.lower():
- try_config[master][builder] = ['defaulttests']
- return try_config
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698