Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 214693010: Remove USE_X11==1 check when including OutputConfigurator (Closed)

Created:
6 years, 9 months ago by dnicoara
Modified:
6 years, 8 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, tfarina, sadrul, kalyank, ben+ash_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove USE_X11==1 check when including OutputConfigurator This patch allows using OutputConfigurator and helpers to support configration on platforms other than X11 (such as Ozone). This CL depends on https://codereview.chromium.org/214513006/ BUG=333413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260329

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -44 lines) Patch
M apps/shell/browser/shell_desktop_controller.h View 4 chunks +5 lines, -5 lines 0 comments Download
M apps/shell/browser/shell_desktop_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/ash.gyp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M ash/display/display_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/display/display_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 4 chunks +1 line, -3 lines 0 comments Download
M ash/shell.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/power_button_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
dnicoara
PTAL This CL gets us closer to having a clean build of ChromeOS on Ozone, ...
6 years, 9 months ago (2014-03-27 19:45:08 UTC) #1
Daniel Erat
lgtm
6 years, 9 months ago (2014-03-27 20:35:16 UTC) #2
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 9 months ago (2014-03-28 18:50:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/214693010/20001
6 years, 9 months ago (2014-03-28 19:00:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 20:21:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-28 20:21:38 UTC) #6
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 9 months ago (2014-03-28 20:33:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/214693010/20001
6 years, 9 months ago (2014-03-28 20:34:43 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 21:38:21 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 21:38:22 UTC) #10
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-03-29 01:12:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/214693010/20001
6 years, 8 months ago (2014-03-29 01:14:38 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 01:18:01 UTC) #13
Message was sent while issue was closed.
Change committed as 260329

Powered by Google App Engine
This is Rietveld 408576698