Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 214693008: Provide correct saveLayer() bounds in FEGaussianBlur, FEMorphology. (Closed)

Created:
6 years, 8 months ago by Stephen White
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Provide correct saveLayer() bounds in FEGaussianBlur, FEMorphology. In Skia r13323, I changed Skia's image filter clipping behaviour to expand clip bounds to accommodate filter margins. However, the legacy Blink DAG already makes such accommodation, which means we're creating an offscreen with redundant pixels. The fix is to specify the computed bounds directly in saveLayer(), which overrides (well, actually intersects) the clip, giving the correct bounds. This does give different results for large blur sigmas, but I believe the new results are spec-correct: the intermediate buffers used by filters should never exceed the size of the filter region. Covered by marked svg tests. BUG= R=schenney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170232

Patch Set 1 #

Patch Set 2 : Add one more test suppression #

Patch Set 3 : Yet more test suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +17 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FEGaussianBlur.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/FEMorphology.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 24 (0 generated)
Stephen White
Florin: PTAL. Thanks!
6 years, 8 months ago (2014-03-27 17:56:00 UTC) #1
Stephen Chennney
LGTM. You are right about the correct behavior for large std filter std deviations.
6 years, 8 months ago (2014-03-27 18:59:31 UTC) #2
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 8 months ago (2014-03-27 19:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/214693008/1
6 years, 8 months ago (2014-03-27 19:06:49 UTC) #4
Stephen White
The CQ bit was unchecked by senorblanco@chromium.org
6 years, 8 months ago (2014-03-27 19:06:55 UTC) #5
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 8 months ago (2014-03-27 19:08:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/214693008/20001
6 years, 8 months ago (2014-03-27 19:08:54 UTC) #7
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 8 months ago (2014-03-27 19:47:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/214693008/40001
6 years, 8 months ago (2014-03-27 19:47:24 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 20:54:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-03-27 20:54:16 UTC) #11
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 8 months ago (2014-03-27 20:55:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/214693008/40001
6 years, 8 months ago (2014-03-27 20:55:43 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 21:17:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-03-27 21:17:29 UTC) #15
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 8 months ago (2014-03-27 21:30:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/214693008/40001
6 years, 8 months ago (2014-03-27 21:30:37 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-27 22:33:00 UTC) #18
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-27 22:33:01 UTC) #19
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 8 months ago (2014-03-27 23:08:36 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/214693008/40001
6 years, 8 months ago (2014-03-27 23:08:44 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 00:15:26 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-03-28 00:15:26 UTC) #23
Stephen White
6 years, 8 months ago (2014-03-28 00:53:52 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 manually as r170232 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698