Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 214693007: Whitelist Cast shared module ids (Closed)

Created:
6 years, 9 months ago by mark a. foltz
Modified:
6 years, 9 months ago
Reviewers:
miket_OOO, Wez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Whitelist Cast shared module ids BUG=357213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
mark a. foltz
6 years, 9 months ago (2014-03-27 17:03:05 UTC) #1
miket_OOO
LGTM. I did not attempt to regenerate the hashes.
6 years, 9 months ago (2014-03-27 17:10:52 UTC) #2
Wez
lgtm
6 years, 9 months ago (2014-03-27 17:48:02 UTC) #3
mark a. foltz
The CQ bit was checked by mfoltz@chromium.org
6 years, 9 months ago (2014-03-27 18:00:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfoltz@chromium.org/214693007/1
6 years, 9 months ago (2014-03-27 18:01:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 20:22:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289612
6 years, 9 months ago (2014-03-27 20:22:44 UTC) #7
mark a. foltz
The CQ bit was checked by mfoltz@chromium.org
6 years, 9 months ago (2014-03-27 21:50:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfoltz@chromium.org/214693007/1
6 years, 9 months ago (2014-03-27 21:51:42 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 00:24:27 UTC) #10
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 00:24:28 UTC) #11
mark a. foltz
The CQ bit was checked by mfoltz@chromium.org
6 years, 9 months ago (2014-03-28 00:25:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfoltz@chromium.org/214693007/1
6 years, 9 months ago (2014-03-28 00:26:38 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:29:42 UTC) #14
Message was sent while issue was closed.
Change committed as 260040

Powered by Google App Engine
This is Rietveld 408576698