Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 214693005: DevTools: [Console] Display timestamps when the Console timestamps setting is re-enabled (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
Reviewers:
eustas, vsevik, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [Console] Display timestamps when the Console timestamps setting is re-enabled Drive-by: Do not subscribe each message to the timestamp display setting but rather the ConsoleMessageView R=eustas, vsevik BUG=357175 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M LayoutTests/inspector/console/console-timestamp.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ConsoleViewMessage.js View 4 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
apavlov
6 years, 9 months ago (2014-03-27 15:07:22 UTC) #1
dgozman
lgtm
6 years, 9 months ago (2014-03-27 15:32:57 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-27 15:35:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/214693005/1
6 years, 9 months ago (2014-03-27 15:35:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:51:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 15:51:32 UTC) #6
eustas
lgtm
6 years, 9 months ago (2014-03-27 16:01:45 UTC) #7
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-27 16:11:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/214693005/1
6 years, 9 months ago (2014-03-27 16:11:37 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 16:12:57 UTC) #10
Message was sent while issue was closed.
Change committed as 170190

Powered by Google App Engine
This is Rietveld 408576698