Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 214693004: Add Layout test to check <select> with -webkit-autofil style (Closed)

Created:
6 years, 9 months ago by ziran.sun
Modified:
6 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add Layout test to check <select> with -webkit-autofil style R=tkent@chromium.org BUG=58719 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M LayoutTests/fast/forms/input-autofilled.html View 4 chunks +25 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/input-autofilled-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ziran.sun
Added layout test to check <select> with -webkit-autofil style. Please review. Thanks!
6 years, 9 months ago (2014-03-27 14:32:19 UTC) #1
tkent
lgtm. This CL is great. However I think we need to add a pixel test ...
6 years, 9 months ago (2014-03-27 22:50:43 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-27 22:50:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/214693004/1
6 years, 9 months ago (2014-03-27 22:50:55 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 23:53:25 UTC) #5
Message was sent while issue was closed.
Change committed as 170225

Powered by Google App Engine
This is Rietveld 408576698