Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 2146923002: Convert auto-play-in-sandbox* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert auto-play-in-sandbox* tests to testharness.js Cleaning up auto-play-in-sandbox* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/66f2fa7fc9c02fe7929245a915433602c956a959 Cr-Commit-Position: refs/heads/master@{#405259}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -36 lines) Patch
M third_party/WebKit/LayoutTests/media/auto-play-in-sandbox-with-allow-scripts.html View 1 chunk +19 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/auto-play-in-sandbox-with-allow-scripts-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html View 1 1 chunk +2 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-13 15:42:25 UTC) #3
fs
lgtm https://codereview.chromium.org/2146923002/diff/1/third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html File third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html (right): https://codereview.chromium.org/2146923002/diff/1/third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html#newcode1 third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html:1: <base href=".."> Nit: Maybe add doctype?
4 years, 5 months ago (2016-07-13 16:09:11 UTC) #4
Srirama
https://codereview.chromium.org/2146923002/diff/1/third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html File third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html (right): https://codereview.chromium.org/2146923002/diff/1/third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html#newcode1 third_party/WebKit/LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html:1: <base href=".."> On 2016/07/13 16:09:11, fs (ooo to July ...
4 years, 5 months ago (2016-07-13 17:17:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146923002/20001
4 years, 5 months ago (2016-07-13 17:18:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 20:12:25 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:14:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66f2fa7fc9c02fe7929245a915433602c956a959
Cr-Commit-Position: refs/heads/master@{#405259}

Powered by Google App Engine
This is Rietveld 408576698