components/flags_ui/feature_entry_macros.h - Issue 2146903002: Clean-up the code for default variations in chrome://flags.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/flags_ui/feature_entry_macros.h

Issue 2146903002: Clean-up the code for default variations in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: iOS test crash fix? #2 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/flags_ui/feature_entry.cc ('k') | components/flags_ui/flags_state.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_	5 #ifndef COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_

6 #define COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_	6 #define COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9	9

10 // Macros to simplify specifying the type of FeatureEntry. Please refer to	10 // Macros to simplify specifying the type of FeatureEntry. Please refer to

(...skipping 17 matching lines...) Expand all Loading...
28 ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(enable_switch, "", disable_switch, "")	28 ENABLE_DISABLE_VALUE_TYPE_AND_VALUE(enable_switch, "", disable_switch, "")

29 #define MULTI_VALUE_TYPE(choices) \	29 #define MULTI_VALUE_TYPE(choices) \

30 flags_ui::FeatureEntry::MULTI_VALUE, nullptr, nullptr, nullptr, nullptr, \	30 flags_ui::FeatureEntry::MULTI_VALUE, nullptr, nullptr, nullptr, nullptr, \

31 nullptr, arraysize(choices), choices, nullptr, nullptr	31 nullptr, arraysize(choices), choices, nullptr, nullptr

32 #define FEATURE_VALUE_TYPE(feature) \	32 #define FEATURE_VALUE_TYPE(feature) \

33 flags_ui::FeatureEntry::FEATURE_VALUE, nullptr, nullptr, nullptr, nullptr, \	33 flags_ui::FeatureEntry::FEATURE_VALUE, nullptr, nullptr, nullptr, nullptr, \

34 &feature, 3, nullptr, nullptr, nullptr	34 &feature, 3, nullptr, nullptr, nullptr

35 #define FEATURE_WITH_VARIATIONS_VALUE_TYPE(feature, feature_variations, \	35 #define FEATURE_WITH_VARIATIONS_VALUE_TYPE(feature, feature_variations, \

36 feature_trial) \	36 feature_trial) \

37 flags_ui::FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE, nullptr, nullptr, \	37 flags_ui::FeatureEntry::FEATURE_WITH_VARIATIONS_VALUE, nullptr, nullptr, \

38 nullptr, nullptr, &feature, 2 + arraysize(feature_variations), nullptr, \	38 nullptr, nullptr, &feature, 3 + arraysize(feature_variations), nullptr, \

39 feature_variations, feature_trial	39 feature_variations, feature_trial

40	40

41 #endif // COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_	41 #endif // COMPONENTS_FLAGS_UI_FEATURE_ENTRY_MACROS_H_

OLD	NEW