Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2146863002:
More unittests of ntp_snippets_fetcher that depend on trial param value. (Closed)
|
Created:
4 years, 5 months ago by jkrcal Modified:
4 years, 5 months ago Reviewers:
Marc Treib CC:
chromium-reviews, ntp-dev+reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@finch-parameters-test Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMore unittests of ntp_snippets_fetcher that depend on trial param value.
This CL recovers tests temporarily removed by CL 2041783002. It also
updates the code to use the extended variation::testing API for
changing values of variation parameters.
Committed: https://crrev.com/66323a04bb2eda8522cbeed5b2d1429f14303951
Cr-Commit-Position: refs/heads/master@{#406556}
Patch Set 1 #Patch Set 2 : Rebase #
Total comments: 2
Patch Set 3 : Marc's comments #Messages
Total messages: 21 (12 generated)
The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jkrcal@chromium.org changed reviewers: + treib@chromium.org
Marc, you saw me removing the unit-tests of the fetcher that depended on host-restriction being on. Here, they are back! PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm Yay! https://codereview.chromium.org/2146863002/diff/20001/components/ntp_snippets... File components/ntp_snippets/ntp_snippets_fetcher_unittest.cc (right): https://codereview.chromium.org/2146863002/diff/20001/components/ntp_snippets... components/ntp_snippets/ntp_snippets_fetcher_unittest.cc:231: {"fetching_host_restrict", "on"}}) {} Out of curiosity: Is the "std::map<...>" required here (and above), or could you just pass the initializer list?
Thanks! https://codereview.chromium.org/2146863002/diff/20001/components/ntp_snippets... File components/ntp_snippets/ntp_snippets_fetcher_unittest.cc (right): https://codereview.chromium.org/2146863002/diff/20001/components/ntp_snippets... components/ntp_snippets/ntp_snippets_fetcher_unittest.cc:231: {"fetching_host_restrict", "on"}}) {} On 2016/07/20 08:34:45, Marc Treib wrote: > Out of curiosity: Is the "std::map<...>" required here (and above), or could you > just pass the initializer list? You are right, not needed. Thanks!
The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run
The CQ bit was unchecked by jkrcal@chromium.org
The CQ bit was checked by jkrcal@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org Link to the patchset: https://codereview.chromium.org/2146863002/#ps40001 (title: "Marc's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by jkrcal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== More unittests of ntp_snippets_fetcher that depend on trial param value. This CL recovers tests temporarily removed by CL 2041783002. It also updates the code to use the extended variation::testing API for changing values of variation parameters. ========== to ========== More unittests of ntp_snippets_fetcher that depend on trial param value. This CL recovers tests temporarily removed by CL 2041783002. It also updates the code to use the extended variation::testing API for changing values of variation parameters. Committed: https://crrev.com/66323a04bb2eda8522cbeed5b2d1429f14303951 Cr-Commit-Position: refs/heads/master@{#406556} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/66323a04bb2eda8522cbeed5b2d1429f14303951 Cr-Commit-Position: refs/heads/master@{#406556} |
