Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 2146853004: [wasm] Drop old typing-asm and its tests. (Closed)

Created:
4 years, 5 months ago by bradnelson
Modified:
4 years, 5 months ago
Reviewers:
bradn, John
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Drop old typing-asm and its tests. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST= cctest/asmjs/test-asm-typer LOG=N R=jpp@chromium.org Committed: https://crrev.com/b0711ccc7060b5b21aa9c41b91812480f360c86f Cr-Commit-Position: refs/heads/master@{#37734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4479 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D src/asmjs/typing-asm.h View 1 chunk +0 lines, -190 lines 0 comments Download
D src/asmjs/typing-asm.cc View 1 chunk +0 lines, -1606 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/wasm/wasm-js.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D test/cctest/asmjs/test-typing-asm.cc View 1 chunk +0 lines, -2464 lines 0 comments Download
M test/cctest/cctest.gyp View 3 chunks +0 lines, -4 lines 0 comments Download
D test/cctest/expression-type-collector.h View 1 chunk +0 lines, -43 lines 0 comments Download
D test/cctest/expression-type-collector.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D test/cctest/test-ast-expression-visitor.cc View 1 chunk +0 lines, -102 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bradn
Any reason not to drop the old one? :-)!
4 years, 5 months ago (2016-07-13 23:38:15 UTC) #3
John
lgtm
4 years, 5 months ago (2016-07-13 23:43:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146853004/1
4 years, 5 months ago (2016-07-13 23:43:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 00:04:33 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 00:06:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0711ccc7060b5b21aa9c41b91812480f360c86f
Cr-Commit-Position: refs/heads/master@{#37734}

Powered by Google App Engine
This is Rietveld 408576698