Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2146843002: [telemetry] Re-enable key event tests on Mac (Closed)

Created:
4 years, 5 months ago by petrcermak
Modified:
4 years, 5 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[telemetry] Re-enable key event tests on Mac Rationale: The bug causing the test to fail on Mac should be fixed now (see http://crbug.com/627221). BUG=chromium:627221 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8b7bf3c29a56101278fa3cb1ce5a2f682ee11f2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M telemetry/telemetry/internal/actions/action_runner_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/actions/key_event_unittest.py View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 5 months ago (2016-07-13 12:37:55 UTC) #3
nednguyen
lgtm
4 years, 5 months ago (2016-07-13 12:38:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146843002/1
4 years, 5 months ago (2016-07-13 12:40:13 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 13:04:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698