Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2146833003: Remove a now unneeded NOLINT (Closed)

Created:
4 years, 5 months ago by Luis Héctor Chávez
Modified:
4 years, 5 months ago
Reviewers:
Georges Khalil
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a now unneeded NOLINT Now that cpplint.py doesn't trigger a false positive with base::hash_map, we don't need the NOLINT tag anymore. BUG=627202 TEST=git cl lint # clean output Committed: https://crrev.com/c266ae372af8fff6fc0ef7255edab5e6d5453bd4 Cr-Commit-Position: refs/heads/master@{#405263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/memory/tab_manager_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Luis Héctor Chávez
PTAL
4 years, 5 months ago (2016-07-13 17:46:00 UTC) #4
Georges Khalil
lgtm
4 years, 5 months ago (2016-07-13 17:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146833003/1
4 years, 5 months ago (2016-07-13 18:33:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:15:57 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 20:16:37 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:19:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c266ae372af8fff6fc0ef7255edab5e6d5453bd4
Cr-Commit-Position: refs/heads/master@{#405263}

Powered by Google App Engine
This is Rietveld 408576698