Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Issue 2146833002: Move webp_transcode to ios/chrome/browser (Closed)

Created:
4 years, 5 months ago by droger
Modified:
4 years, 5 months ago
Reviewers:
jam, sdefresne
CC:
chromium-reviews, blundell+watchlist_chromium.org, cbentzel+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move webp_transcode to ios/chrome/browser webp_transcode is now only used from ios/chrome/browser. BUG=627509 TBR=jam Committed: https://crrev.com/2b36a509e01ac8858170a255d9c0780bdf3bde16 Cr-Commit-Position: refs/heads/master@{#405982}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix OWNERS #

Patch Set 4 : Cleanup DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -743 lines) Patch
M components/BUILD.gn View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/OWNERS View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M components/components.gyp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M components/components_tests.gyp View 1 3 chunks +1 line, -5 lines 0 comments Download
D components/test/data/webp_transcode/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/test/data/webp_transcode/test.jpg View Binary file 0 comments Download
D components/test/data/webp_transcode/test.webp View Binary file 0 comments Download
D components/test/data/webp_transcode/test_alpha.png View Binary file 0 comments Download
D components/test/data/webp_transcode/test_alpha.webp View Binary file 0 comments Download
D components/test/data/webp_transcode/test_small.tiff View Binary file 0 comments Download
D components/test/data/webp_transcode/test_small.webp View Binary file 0 comments Download
M components/webp_transcode.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
D components/webp_transcode/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
D components/webp_transcode/DEPS View 1 chunk +0 lines, -12 lines 0 comments Download
D components/webp_transcode/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/webp_transcode/README View 1 chunk +0 lines, -2 lines 0 comments Download
D components/webp_transcode/webp_decoder.h View 1 chunk +0 lines, -78 lines 0 comments Download
D components/webp_transcode/webp_decoder.mm View 1 chunk +0 lines, -252 lines 0 comments Download
D components/webp_transcode/webp_decoder_unittest.mm View 1 chunk +0 lines, -291 lines 0 comments Download
M ios/chrome/BUILD.gn View 1 2 chunks +7 lines, -0 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/net/image_fetcher.mm View 1 chunk +1 line, -1 line 0 comments Download
A ios/chrome/browser/webp_transcode/DEPS View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A + ios/chrome/browser/webp_transcode/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/chrome/browser/webp_transcode/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/chrome/browser/webp_transcode/webp_decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ios/chrome/browser/webp_transcode/webp_decoder.mm View 1 chunk +1 line, -1 line 0 comments Download
A + ios/chrome/browser/webp_transcode/webp_decoder_unittest.mm View 3 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 3 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 2 chunks +2 lines, -1 line 0 comments Download
A + ios/chrome/test/data/webp_transcode/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ios/chrome/test/data/webp_transcode/test.jpg View Binary file 0 comments Download
A + ios/chrome/test/data/webp_transcode/test.webp View Binary file 0 comments Download
A + ios/chrome/test/data/webp_transcode/test_alpha.png View Binary file 0 comments Download
A + ios/chrome/test/data/webp_transcode/test_alpha.webp View Binary file 0 comments Download
A + ios/chrome/test/data/webp_transcode/test_small.tiff View Binary file 0 comments Download
A + ios/chrome/test/data/webp_transcode/test_small.webp View Binary file 0 comments Download

Messages

Total messages: 50 (39 generated)
droger
4 years, 5 months ago (2016-07-13 14:27:30 UTC) #22
droger
ping
4 years, 5 months ago (2016-07-18 08:32:19 UTC) #30
sdefresne
lgtm
4 years, 5 months ago (2016-07-18 13:00:59 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146833002/160001
4 years, 5 months ago (2016-07-18 13:20:59 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/219605)
4 years, 5 months ago (2016-07-18 13:27:34 UTC) #38
droger
TBR jam for the new dep on libwebp in ios/chrome/browser/webp_transcode. This is just a code ...
4 years, 5 months ago (2016-07-18 13:33:24 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146833002/180001
4 years, 5 months ago (2016-07-18 13:33:56 UTC) #44
commit-bot: I haz the power
Committed patchset #4 (id:180001)
4 years, 5 months ago (2016-07-18 14:15:09 UTC) #46
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 14:15:21 UTC) #47
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2b36a509e01ac8858170a255d9c0780bdf3bde16 Cr-Commit-Position: refs/heads/master@{#405982}
4 years, 5 months ago (2016-07-18 14:17:05 UTC) #49
jam
4 years, 5 months ago (2016-07-18 17:43:21 UTC) #50
Message was sent while issue was closed.
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698