Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 214683002: NativeContext::map_cache reference should be strong in heap snapshots (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

NativeContext::map_cache reference should be strong in heap snapshots This change makes the reference itself a strong one. We will also need a special handling to make references from MapCache object to Map weak in the heap snapshots. The latter will be addressed separately. BUG=chromium:357060 LOG=Y R=alph@chromium.org, hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
yurys
6 years, 9 months ago (2014-03-27 12:55:53 UTC) #1
yurys
6 years, 9 months ago (2014-03-27 12:57:19 UTC) #2
alph
lgtm
6 years, 9 months ago (2014-03-27 12:58:22 UTC) #3
Hannes Payer (out of office)
lgtm
6 years, 9 months ago (2014-03-27 13:38:57 UTC) #4
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-27 14:10:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/yurys@chromium.org/214683002/1
6 years, 9 months ago (2014-03-27 14:11:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:11:04 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-27 14:11:04 UTC) #8
yurys
6 years, 9 months ago (2014-03-27 14:19:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r20304 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698