Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2146793003: Revert of Improve ios/web/public/test/web_js_test.h (Closed)

Created:
4 years, 5 months ago by vabr (Chromium)
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@627775_all_in_one
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Improve ios/web/public/test/web_js_test.h (patchset #2 id:20001 of https://codereview.chromium.org/2148723003/ ) Reason for revert: I'm afraid DCHECK_NSEQ is not defined, just EXPECT and ASSERT. It seems to break compilation downstream. Let me revert and fix. Vaclav Original issue's description: > Improve ios/web/public/test/web_js_test.h > > This CL does some minor changes to web_js_test.h based on eugenebut's > recommendations in https://codereview.chromium.org/2150513002/#msg21. > > R=eugenebut@chromium.org > BUG=627775 > > Committed: https://crrev.com/2de879b6567bdd5383db462d0d3ee194bb4d998b > Cr-Commit-Position: refs/heads/master@{#405234} TBR=eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=627775 Committed: https://crrev.com/8ca0f9d3ef6d401ef92c8a19cc8e7d1a268ccace Cr-Commit-Position: refs/heads/master@{#405280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ios/web/public/test/web_js_test.h View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
vabr (Chromium)
Created Revert of Improve ios/web/public/test/web_js_test.h
4 years, 5 months ago (2016-07-13 20:35:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146793003/1
4 years, 5 months ago (2016-07-13 20:36:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:37:29 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 20:37:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8ca0f9d3ef6d401ef92c8a19cc8e7d1a268ccace Cr-Commit-Position: refs/heads/master@{#405280}
4 years, 5 months ago (2016-07-13 20:40:14 UTC) #8
Eugene But (OOO till 7-30)
4 years, 5 months ago (2016-07-13 20:44:21 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698