[Stream] Notify ReadObserver of Stream abortion

[Stream] Notify ReadObserver of Stream abortion

Currently there is no means to get notified when a content::Stream is aborted.
As a result, when a fetch body stream created in a ServiceWorker is get
errored, that error is not notified to the page. This CL fixes that problem by
calling ReadObserver::OnDataAvailable when a content::Stream is aborted.

BUG=627046
Committed: https://crrev.com/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d
Cr-Commit-Position: refs/heads/master@{#406553}

[yhirano, 2016-07-13 04:48:57]

yhirano@chromium.org changed reviewers:
+ falken@chromium.org, tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-07-13 06:09:36]

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-iframe.html
(right):

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-iframe.html:3:
<title>respond-with-response-stream-with-invalid-chunk</title>
stream -> body?

or use stream for there and the filename?

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-iframe.html:10:
() => parent.done('Pass'));
PASS?

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html
(right):

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html:28:
.then(result => assert_equals(result, 'Pass'));
PASS?

[yhirano, 2016-07-13 10:35:56]

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-iframe.html
(right):

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-iframe.html:3:
<title>respond-with-response-stream-with-invalid-chunk</title>
On 2016/07/13 06:09:35, tyoshino wrote:
> stream -> body?
> 
> or use stream for there and the filename?

Done.

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-iframe.html:10:
() => parent.done('Pass'));
On 2016/07/13 06:09:35, tyoshino wrote:
> PASS?

Done.

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html
(right):

https://codereview.chromium.org/2146773002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html:28:
.then(result => assert_equals(result, 'Pass'));
On 2016/07/13 06:09:35, tyoshino wrote:
> PASS?

Done.

[tyoshino (SeeGerritForStatus), 2016-07-13 10:43:21]

lgtm

[falken, 2016-07-14 13:00:43]

lgtm with comment

https://codereview.chromium.org/2146773002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html
(right):

https://codereview.chromium.org/2146773002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html:18:
// body blob. The service worker confirms it can read the blob and responds
This description doesn't seem to match this test.

[yhirano, 2016-07-14 13:21:28]

yhirano@chromium.org changed reviewers:
+ zork@google.com

[yhirano, 2016-07-14 13:21:29]

+zork@ for OWNER review

[yhirano, 2016-07-14 13:30:54]

https://codereview.chromium.org/2146773002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html
(right):

https://codereview.chromium.org/2146773002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html:18:
// body blob. The service worker confirms it can read the blob and responds
On 2016/07/14 13:00:43, falken wrote:
> This description doesn't seem to match this test.

Done.

[yhirano, 2016-07-19 00:18:45]

zork: ping

[yhirano, 2016-07-20 05:06:43]

yhirano@chromium.org changed reviewers:
+ kinuko@chromium.org

[yhirano, 2016-07-20 05:06:44]

Hmm, zork@ looks no longer active. kinuko@, can you take a look at content
changes?

[kinuko, 2016-07-20 06:35:59]

lgtm

https://codereview.chromium.org/2146773002/diff/60001/content/browser/streams...
File content/browser/streams/stream.cc (right):

https://codereview.chromium.org/2146773002/diff/60001/content/browser/streams...
content/browser/streams/stream.cc:80: // Continue asynchronously.
nit: A bit more detailed comment might be helpful... e.g. "Next Read will return
STREAM_ABORTED as reader_ is reset to null"

[yhirano, 2016-07-20 11:29:47]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[yhirano, 2016-07-20 11:30:20]

https://codereview.chromium.org/2146773002/diff/60001/content/browser/streams...
File content/browser/streams/stream.cc (right):

https://codereview.chromium.org/2146773002/diff/60001/content/browser/streams...
content/browser/streams/stream.cc:80: // Continue asynchronously.
On 2016/07/20 06:35:59, kinuko wrote:
> nit: A bit more detailed comment might be helpful... e.g. "Next Read will
return
> STREAM_ABORTED as reader_ is reset to null"

Done.

[commit-bot: I haz the power, 2016-07-20 11:30:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 11:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 11:51:44]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[yhirano, 2016-07-20 12:24:29]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-07-20 12:24:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, falken@chromium.org, kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2146773002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-07-20 12:25:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 12:51:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 12:51:25]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[yhirano, 2016-07-20 13:32:35]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-07-20 13:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 14:47:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-20 14:47:12]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 14:49:04]

Description was changed from

==========
[Stream] Notify ReadObserver of Stream abortion

Currently there is no means to get notified when a content::Stream is aborted.
As a result, when a fetch body stream created in a ServiceWorker is get
errored, that error is not notified to the page. This CL fixes that problem by
calling ReadObserver::OnDataAvailable when a content::Stream is aborted.

BUG=627046
==========

to

==========
[Stream] Notify ReadObserver of Stream abortion

Currently there is no means to get notified when a content::Stream is aborted.
As a result, when a fetch body stream created in a ServiceWorker is get
errored, that error is not notified to the page. This CL fixes that problem by
calling ReadObserver::OnDataAvailable when a content::Stream is aborted.

BUG=627046

Committed: https://crrev.com/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d
Cr-Commit-Position: refs/heads/master@{#406553}
==========

[commit-bot: I haz the power, 2016-07-20 14:49:05]

Patchset 5 (id:??) landed as
https://crrev.com/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d
Cr-Commit-Position: refs/heads/master@{#406553}