[ios] Cleaned up deprecated SSLError delegate method.

[ios] Cleaned up deprecated SSLError delegate method.

presentSSLError:forSSLStatus:recoverable:callback: is not implemented
by Tab anymore.

BUG=602298
Committed: https://crrev.com/de007c43c14df3f96a782b8a7f0ef0fcbc7e32bc
Cr-Commit-Position: refs/heads/master@{#406011}

[Eugene But (OOO till 7-30), 2016-07-13 23:00:16]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 23:00:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-07-13 23:04:55]

eugenebut@chromium.org changed reviewers:
+ marq@chromium.org

[commit-bot: I haz the power, 2016-07-14 00:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 00:06:27]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2016-07-18 09:34:13]

LGTM with a nit.

https://codereview.chromium.org/2146763003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2146763003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:4547:
web::GetWebClient()->AllowCertificateError(
nit: It's not clear what part of this call induces the interstitial to be
presented. (a method with six parameters is also a problem, but that's outside
of the scope of this CL). If this comment isn't accurate, and this isn't what
displays the cert error, it should be updated.

[Eugene But (OOO till 7-30), 2016-07-18 15:44:17]

Thanks!

https://codereview.chromium.org/2146763003/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2146763003/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:4547:
web::GetWebClient()->AllowCertificateError(
On 2016/07/18 09:34:13, marq wrote:
> nit: It's not clear what part of this call induces the interstitial to be
> presented. (a method with six parameters is also a problem, but that's outside
> of the scope of this CL). If this comment isn't accurate, and this isn't what
> displays the cert error, it should be updated.
Good point. Updated the comment to be more generic, as mentioning interstitials
is not actually helpful.

Concerning 6 parameters. As I mentioned before this method with 6 parameters
mirrors a content// method which has 10 parameters and we intentionally choose
to be as close to content API as possible.

[Eugene But (OOO till 7-30), 2016-07-18 15:44:21]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-07-18 15:44:21]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2146763003/#ps20001
(title: "Updated comments")

[commit-bot: I haz the power, 2016-07-18 15:44:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 16:24:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-18 16:25:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 16:26:09]

Description was changed from

==========
[ios] Cleaned up deprecated SSLError delegate method.

presentSSLError:forSSLStatus:recoverable:callback: is not implemented
by Tab anymore.

BUG=602298
==========

to

==========
[ios] Cleaned up deprecated SSLError delegate method.

presentSSLError:forSSLStatus:recoverable:callback: is not implemented
by Tab anymore.

BUG=602298

Committed: https://crrev.com/de007c43c14df3f96a782b8a7f0ef0fcbc7e32bc
Cr-Commit-Position: refs/heads/master@{#406011}
==========

[commit-bot: I haz the power, 2016-07-18 16:26:10]

Patchset 2 (id:??) landed as
https://crrev.com/de007c43c14df3f96a782b8a7f0ef0fcbc7e32bc
Cr-Commit-Position: refs/heads/master@{#406011}