blimp/client/core/android/blimp_jni_registrar.cc - Issue 2146753002: Android: Remove unneeded RegisterNatives() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/android/blimp_jni_registrar.cc

Issue 2146753002: Android: Remove unneeded RegisterNatives() calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, more fixes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/android/blimp_jni_registrar.cc

diff --git a/blimp/client/core/android/blimp_jni_registrar.cc b/blimp/client/core/android/blimp_jni_registrar.cc

index 9e71b79660d6d085db78150dc5363725cffef08b..d4dce1c13075fa4f87c64841193ca9c3852b88f1 100644

--- a/blimp/client/core/android/blimp_jni_registrar.cc

+++ b/blimp/client/core/android/blimp_jni_registrar.cc

@@ -21,9 +21,7 @@ base::android::RegistrationMethod kBlimpRegistrationMethods[] = {

} // namespace

// This method is declared in

-// //blimp/client/public/android/blimp_jni_registrar.h, and either this function

-// or the one in //blimp/client/core/android/dummy_blimp_jni_registrar.cc

-// should be linked in to any binary blimp::client::RegisterBlimpJni.

+// //blimp/client/public/android/blimp_jni_registrar.h.

bool RegisterBlimpJni(JNIEnv* env) {

return base::android::RegisterNativeMethods(

env, kBlimpRegistrationMethods, arraysize(kBlimpRegistrationMethods));