base/android/jni_generator/testMultipleJNIAdditionalImport.golden - Issue 2146753002: Android: Remove unneeded RegisterNatives() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/testMultipleJNIAdditionalImport.golden

Issue 2146753002: Android: Remove unneeded RegisterNatives() calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, more fixes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/jni_generator/testMultipleJNIAdditionalImport.golden

diff --git a/base/android/jni_generator/testMultipleJNIAdditionalImport.golden b/base/android/jni_generator/testMultipleJNIAdditionalImport.golden

index c9b297f79757ed588dd8e1c8a8f20ad2c00baaab..7d55a6b612c9fec4863463e03390c4c518087ea8 100644

--- a/base/android/jni_generator/testMultipleJNIAdditionalImport.golden

+++ b/base/android/jni_generator/testMultipleJNIAdditionalImport.golden

@@ -43,7 +43,6 @@ void Java_org_chromium_foo_Foo_nativeDoSomething(JNIEnv* env, jclass jcaller,

static base::subtle::AtomicWord g_Foo_calledByNative = 0;

static void Java_Foo_calledByNative(JNIEnv* env, jobject callback1,

jobject callback2) {

- /* Must call RegisterNativesImpl() */

CHECK_CLAZZ(env, Foo_clazz(env),

Foo_clazz(env));

jmethodID method_id =

@@ -65,8 +64,6 @@ static void Java_Foo_calledByNative(JNIEnv* env, jobject callback1,

}

-// Step 3: RegisterNatives.

static const JNINativeMethod kMethodsFoo[] = {

{ "nativeDoSomething",

"("