device/vr/android/cardboard/cardboard_vr_device.cc - Issue 2146753002: Android: Remove unneeded RegisterNatives() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/android/cardboard/cardboard_vr_device.cc

Issue 2146753002: Android: Remove unneeded RegisterNatives() calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android: Don't require RegisterNatives if there are none Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/android/cardboard/cardboard_vr_device.cc

diff --git a/device/vr/android/cardboard/cardboard_vr_device.cc b/device/vr/android/cardboard/cardboard_vr_device.cc

index ed24bb92838f9a595498240feaa834d40507bc46..70176119960913a0ecd0443e9aa2843ab013bdff 100644

--- a/device/vr/android/cardboard/cardboard_vr_device.cc

+++ b/device/vr/android/cardboard/cardboard_vr_device.cc

@@ -23,10 +23,6 @@ using base::android::AttachCurrentThread;

namespace device {

-bool CardboardVRDevice::RegisterCardboardVRDevice(JNIEnv* env) {

- return RegisterNativesImpl(env);

CardboardVRDevice::CardboardVRDevice(VRDeviceProvider* provider)

: VRDevice(provider) {

JNIEnv* env = AttachCurrentThread();