components/ntp_tiles/most_visited_sites.cc - Issue 2146753002: Android: Remove unneeded RegisterNatives() calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/most_visited_sites.cc

Issue 2146753002: Android: Remove unneeded RegisterNatives() calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android: Don't require RegisterNatives if there are none Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/most_visited_sites.cc

diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc

index 0e0aa878e46b06bad42a26f3beeb417dc396b22a..894d83f4045b6f2289c8a29e8b06d69adc5afcab 100644

--- a/components/ntp_tiles/most_visited_sites.cc

+++ b/components/ntp_tiles/most_visited_sites.cc

@@ -174,13 +174,6 @@ MostVisitedSites::~MostVisitedSites() {

supervisor_->SetObserver(nullptr);

}

-#if defined(OS_ANDROID)

-// static

-bool MostVisitedSites::Register(JNIEnv* env) {

- return RegisterNativesImpl(env);

-#endif

void MostVisitedSites::SetMostVisitedURLsObserver(Observer* observer,

int num_sites) {

DCHECK(observer);